[TORQUE-365] CountHelper doesn't work, when Criteria has "setDisctint()"

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.1
• Fix Version/s: 6.0
• Component/s: Runtime
• Labels: CountHelper distinct
• Assignee: Unassigned
• Reporter: Max Philipp Wriedt
• Created: 15/Apr/23 20:10
• Updated: 08/May/24 09:17
• Resolved: 08/May/24 09:17

Description

When passing a Criteria which has been modified with "setDistinct()" the CountHelper creates a wrong SQL-Statement containing "SELECT COUNT(DISTINCT *)". This is not valid SQL.

A common workaround is to set a column to count while creating the CountHelper.

If I am not wrong we could also solve this problem inside the count()-function of the CountHelper itself, as there is already a handler for DISTINCT cases.

boolean distinct = isAndSetDistinct(criteriaSelectModifiers) && !Objects.equals(columnName, "*"); // org.apache.torque.utils.CountHelper:202

This could probably set "DISTINCT" directly behind the SELECT, but not inside the "COUNT()" clause, generating at least valid SQL.