Torque
  1. Torque
  2. TORQUE-178

Change semantics of add() and or() methods in Criteria

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.0-beta1
    • Component/s: Runtime, Templates
    • Labels:
      None

      Description

      In my opinion, the Criteria.add() and Criteria.or() method behave counter-intuitively. My opinion of an intuitive behaviour would be:

      • Criteria.or(someCondition) should result in a where clause which contains ((whatever was in the where condition before) OR someCondition)
      • Criteria.add(someCondition) should result in a where clause which contains ((whatever was in the where condition before) AND someCondition), i.e. the same as Criteria.and(someCondition)

      Instead, the behaviour is now

      • Criteria.or(someCondition) only or's the new condition with any existing condition(s) that affects the same column.
      • Criteria.add(someCondition) replaces any existing condition(s) that affects the same column with the new condition.

        Activity

        Thomas Fox created issue -
        Thomas Fox made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Thomas Fox made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Thomas Fox
            Reporter:
            Thomas Fox
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development