Uploaded image for project: 'Torque'
  1. Torque
  2. TORQUE-119

Method "save" doesn't handle exceptions which results in unsavable objects

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.3
    • 4.0-beta1
    • Generator
    • None

    Description

      In the method "public void save(Connection con) throws TorqueException" (generated by templates>om>Object) the field "alreadyInSave" indicates that there is an ongoing save process. In the beginning it is set to "true", at the end it is set back to "false". But if an exception occurs (while calling doInsert(...) or doUpdate(...)) this field will not be set back to false 'cause the method throws this exception immediately. So afterwards it isn't possible to save an object using this method.

      proposal for fix:
      Wrap the "internal" of the save method with a "try

      { ... } finally { ... }

      " - statement and in the finally set the field "alreadyInSave" to false.

      Attachments

        Activity

          People

            tfischer Thomas Fox
            f.liese Florian Liese
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: