[TOMEE-4108] Backport TOMEE-4065: LoginToContinue interceptor fails on custom auth mechanism

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 8.0.13
• Fix Version/s: 8.0.14

Language

Java

• Assignee: Unassigned
• Reporter: Stefan Kalscheuer
• Created: 09/Nov/22 14:44
• Updated: 06/Jan/23 12:15
• Resolved: 06/Jan/23 12:15

Description

I stumbled across an issue using a custom HttpAuthenticationMechanism implementation using the @LoginToContinue annotation directly.

Minimal example code:

@ApplicationScoped
@AutoApplySession
@LoginToContinue
public class AuthMechanism implements HttpAuthenticationMechanism {
  @Override
  public AuthenticationStatus validateRequest(HttpServletRequest request,
                                              HttpServletResponse response,
                                              HttpMessageContext httpMessageContext) throws AuthenticationException {
    /* do auth stuff */
  }
} 

 

Expected behavior

I would expect the application server to redirect any request to a protected URL to the login page (without additional specification this would be "/login" here).

 

Observable behavior

Apparently this raises an error 500:

java.lang.IllegalArgumentException     org.apache.tomee.security.cdi.LoginToContinueInterceptor.getLoginToContinue(LoginToContinueInterceptor.java:221)   org.apache.tomee.security.cdi.LoginToContinueInterceptor.processContainerInitiatedAuthentication(LoginToContinueInterceptor.java:134)   org.apache.tomee.security.cdi.LoginToContinueInterceptor.validateRequest(LoginToContinueInterceptor.java:78)   org.apache.tomee.security.cdi.LoginToContinueInterceptor.intercept(LoginToContinueInterceptor.java:63)
...

 

The interceptor checks whether the invocation  target implements LoginToContinueMechanism and calls getLoginToContinue(). Because we do have a custom implementation here, this does not apply and raises an exception.

 

Possible solution

My workaround is a minor extension of the interceptor, i.e. add a fallback to a class-level annotation of the target.

private LoginToContinue getLoginToContinue(final InvocationContext invocationContext) {
  if (invocationContext.getTarget() instanceof LoginToContinueMechanism) {
    return ((LoginToContinueMechanism) invocationContext.getTarget()).getLoginToContinue();
  }

  // WORKAROUND START
  LoginToContinue annotation = invocationContext.getTarget().getClass().getAnnotation(LoginToContinue.class);
  if (annotation != null) {
    return annotation;
  }
  // WORKAROUND END

  throw new IllegalArgumentException();
}

 

RFC

Did I miss or misinterpret anything here or should the behavior of the interceptor be extended, e.g. with the lines proposed above?

Issue Links

• is a clone of: TOMEE-4065 LoginToContinue interceptor fails on custom auth mechanism
• links to: GitHub Pull Request #961