Uploaded image for project: 'TomEE'
  1. TomEE
  2. TOMEE-2756

Typo in the DeploymentsResolver causes excluding all URLs

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 7.0.5
    • Fix Version/s: None
    • Component/s: TomEE Core Server
    • Labels:
      None
    • Environment:
      Ubuntu 18.04, Embedded TomEE 7.0.5

      Description

      In the project: openejb-core
      Is in the package: org.apache.openejb.config
      Class: DeploymentsResolver
      Method: loadFromClasspath
      Line: 264

      There is typo there from refactoring done 5 years ago, which prevent us from upgrading.
      Current code:

      UrlSet unchecked = new UrlSet();            if (!searchResult.filterDescriptors) {
                      unchecked = NewLoaderLogic.applyBuiltinExcludes(searchResult.prefiltered.exclude(searchResult.prefiltered));
                      if (searchResult.filterSystemApps) {
                          unchecked = unchecked.exclude(".*/openejb-[^/]+(.(jar|ear|war)(./)?|/target/classes/?)");
                      }
                      processUrls("DeploymentsResolver2", unchecked.getUrls(), classLoader, EnumSet.allOf(RequireDescriptors.class), jarList);
                  } 

      In the exclude should be urlSet instead of prefiltered, otherwice all URL are excluded:

      unchecked = NewLoaderLogic.applyBuiltinExcludes(searchResult.prefiltered.exclude(searchResult.urlSet));
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              kubo44 RomanKa
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 0.25h
                0.25h
                Remaining:
                Remaining Estimate - 0.25h
                0.25h
                Logged:
                Time Spent - Not Specified
                Not Specified