[TOMEE-1465] org.apache.openejb.util.PropertyPlaceHolderHelper.PropertiesLookup caches properties

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.1
• Fix Version/s: 7.0.0-M1
• Assignee: Andy Gumbrecht
• Reporter: Andy Gumbrecht
• Created: 02/Dec/14 11:28
• Updated: 28/Jun/16 11:58
• Resolved: 28/Jun/16 11:58

Description

org.apache.openejb.util.PropertyPlaceHolderHelper.PropertiesLookup should not cache SystemInstance.get().getProperties() as this leads to race conditions and rare test failures where test order is not guaranteed. The following illustrates the issue.

SystemInstance.get().setProperty("PropertyPlaceHolderTest1", "bob");
final String bob = PropertyPlaceHolderHelper.simpleValue("j${PropertyPlaceHolderTest1}");

SystemInstance.get().setProperty("PropertyPlaceHolderTest1", "sally");
final String sally = PropertyPlaceHolderHelper.simpleValue("j${PropertyPlaceHolderTest1}");

sally == "bob" <-- As PropertiesLookup is using cached properties from first call.

Calling PropertyPlaceHolderHelper .reset() on SystemInstance.get().setProperty() calls could be an option, but would force a loader dep on core, or moving PropertyPlaceHolderHelper to loader could be an option if it does not break anything.