[TOMAHAWK-878] orgApacheMyfacesSubmitOnEventSetEvent: event is checked for null but window.event is not

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.1.5-SNAPSHOT
• Component/s: submitOnEvent
• Environment: WebTest R_1479, HtmlUnit 1.10, Rhino 1.6R5
• Assignee: Unassigned
• Reporter: Stefan Seidel
• Created: 31/Jan/07 17:28
• Updated: 31/Jan/07 17:28

Description

When using the submitOnEvent in a Canoo WebTest/HtmlUnit Test/with Rhino, it may happen that orgApacheMyfacesSubmitOnEventSetEvent is called with event==null ((!event) evaluates to true). It is then set to window.event, but this is null, also. In this case, JavaScript execution will fail because the cancelBubble property is being tried to be set to true (line 182), but event is null.
Solution is to insert these 4 lines just before "event.cancelBubble = true":

        if (!event)                                                                                                                                                                 
        {                                                                                                                                                                           
            return ret;                                                                                                                                                             
        }