[TOMAHAWK-582] Implementation of the TabChangeListenerTag prevents the use of IOC

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.3
• Fix Version/s: 1.1.4-SNAPSHOT
• Component/s: Tabbed Pane
• Environment: Windows 2000 SP4, JBoss 4.0.3
• Assignee: Martin Marinschek
• Reporter: Tomasz Stanczak
• Created: 04/Aug/06 10:03
• Updated: 25/Jun/11 19:33
• Resolved: 20/Sep/06 19:13

Description

The TabChangeListenerTag class in its current implementation creates always a new instance of the application's TabChangeListener implementation. Thus you cannot provide a preinitialized instance - for example a request configured in faces-config.xml or a Spring bean. Instance reuse is not possible.

It wants a classname of the TabChangeListener implementation class and creates an instance. Even given a JSF expression it doesn't get the instance pointed to by the expression but interprets the expression result as a class name to be instantiated:

String className;
if (UIComponentTag.isValueReference(type))

{ FacesContext facesContext = FacesContext.getCurrentInstance(); ValueBinding valueBinding = facesContext.getApplication().createValueBinding(type); className = (String) valueBinding.getValue(facesContext); }

else

{ className = type; }

TabChangeListener listener = (TabChangeListener) ClassUtils.newInstance(className);
((HtmlPanelTabbedPane) component).addTabChangeListener(listener);

It could be made better by using something like that:

Object refValue = valueBinding.getValue(facesContext);
if (refValue instanceof TabChangeListener)

{ // use the instance found as listener }

else

{ // use the instance found as a class name to be instantiated }