MyFaces Tomahawk
  1. MyFaces Tomahawk
  2. TOMAHAWK-506

Schedule getClickedTime() returns incorrect time in compact views

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.4-SNAPSHOT
    • Fix Version/s: 1.1.5
    • Component/s: Schedule
    • Labels:
      None

      Description

      In the month and week views ScheduleMouseEvent.getClickedTime() returns an incorrect time.

      The date is always the current date, the hour is always 08:00 and the minutes are always the current minutes past the hour.

      I have not yet had a chance to investigate possible causes.

        Activity

        Peter Mahoney created issue -
        Hide
        Jurgen Lust added a comment -

        Actually, this was the way it was intended, except for the minutes part that is. In the compact view, the clicked time is always the visible start time, because this view is just a list of events, without positioning. Therefore, it does not make sense to determine the time of day from the position of the mouse.

        Show
        Jurgen Lust added a comment - Actually, this was the way it was intended, except for the minutes part that is. In the compact view, the clicked time is always the visible start time, because this view is just a list of events, without positioning. Therefore, it does not make sense to determine the time of day from the position of the mouse.
        Hide
        Peter Mahoney added a comment -

        I agree about the time, but the day is always the current date rather than the day that was clicked on. If I click on the 29th June box, I would expect the time to be returned as 29/6/2006 8:00, not 28/6/2006.

        Show
        Peter Mahoney added a comment - I agree about the time, but the day is always the current date rather than the day that was clicked on. If I click on the 29th June box, I would expect the time to be returned as 29/6/2006 8:00, not 28/6/2006.
        Hide
        Jurgen Lust added a comment -

        Aha, then that is in fact a bug I'll look into it this weekend...

        Show
        Jurgen Lust added a comment - Aha, then that is in fact a bug I'll look into it this weekend...
        Hide
        Peter Mahoney added a comment -

        The attached patch fixes both the incorrect day, and incorrect minutes bugs.

        Show
        Peter Mahoney added a comment - The attached patch fixes both the incorrect day, and incorrect minutes bugs.
        Peter Mahoney made changes -
        Field Original Value New Value
        Attachment abstractcompactschedulerenderer.patch [ 12336731 ]
        Peter Mahoney made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Dan added a comment -

        is this patch gonna be applied? it's been a month now.

        Show
        Dan added a comment - is this patch gonna be applied? it's been a month now.
        Hide
        Jurgen Lust added a comment -

        Patch applied. Sorry for the delay, vacation got in the way of things

        Show
        Jurgen Lust added a comment - Patch applied. Sorry for the delay, vacation got in the way of things
        Jurgen Lust made changes -
        Fix Version/s 1.1.5-SNAPSHOT [ 12311959 ]
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Jurgen Lust made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Manfred Geiler made changes -
        Fix Version/s 1.1.5 [ 12312397 ]
        Fix Version/s 1.1.5-SNAPSHOT [ 12311959 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Peter Mahoney
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development