Uploaded image for project: 'MyFaces Tomahawk'
  1. MyFaces Tomahawk
  2. TOMAHAWK-282

AddResource should use the current character encoding

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 1.1.2
    • None
    • None

    Description

      In AddResource.writeWithFullHeader the current character encoding wont be used when instantiating the ResponseWriter.
      This will encode the whole page even if the page is already in UTF-8 - where no further encoding should be done.

      I maked it as blocker as this will break html-embedded-javascripts. All non-ascii characters were encoded and e.g. when alert() them the browser wont decode it.
      But feel free to adjust the priority.

      Attached you will find a patch which will take the response.getCharacterEncoding() - and the adjusted Test-Case.

      Attachments

        1. add_resource_encoding.diff
          2 kB
          Mario Ivankovits

        Activity

          People

            mmarinschek Martin Marinschek
            imario Mario Ivankovits
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: