[TOMAHAWK-1612] Children of h:form within t:panelGroup still get rendered even though their parent (h:form) has rendered=false

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.11
• Fix Version/s: 1.1.12
• Component/s: Html Tag
• Environment: Tomahawk20-1.1.11 and MyFaces 2.1.6 (Tomcat7, Java6)
• Assignee: Leonardo Uribe
• Reporter: Stan Zapryanov
• Created: 07/Mar/12 15:20
• Updated: 19/Apr/12 03:09
• Resolved: 30/Mar/12 20:50

Description

Children of h:form with rendered="false" do get rendered (but should not) IF h:form is placed within t:panelGroup
If t:panelGroup in the example below is changed to h:panelGroup, then everything works correctly (h:form children don't get rendered).

Example demonstrating the bug:

<t:panelGrid>
<t:panelGroup>
<h:form id="testForm" rendered="false">
Stuff inside form should not show but this line shows
</h:form>
</t:panelGroup>
</t:panelGrid>

I did some debugging and it seems to me that the bug is coming from the following change made from Tomahawk20-1.1.10 to Tomahawk20-1.1.11
In class: org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils
Method: public static void renderChild(FacesContext facesContext, UIComponent child) throws IOException
The following lines were removed:

530 if (!child.isRendered())
531

{ 532 return; 533 }

There might be other places where this change could be causing problems/bugs.