[TOMAHAWK-1475] NullPointerException in UpdateActionListener caused by getType()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.9
• Fix Version/s: 1.1.10
• Component/s: UpdateActionListener
• Environment: myfaces 1.2.8; richfaces 3.3.2; tiles 2.0.5; tomcat 6.0.18
• Assignee: Leonardo Uribe
• Reporter: Michael Heinen
• Created: 16/Dec/09 08:17
• Updated: 27/Sep/10 21:36
• Resolved: 02/May/10 01:45

Description

Commands using a t:updateActionListener are not working anymore due to a
java.lang.NullPointerException
at org.apache.myfaces.custom.updateactionlistener.UpdateActionListener.processAction(UpdateActionListener.java:137)

Line 137:
if (!type.equals(String.class) && ! type.equals(Object.class))

Cause:
java.lang.NullPointerException
at org.apache.myfaces.custom.updateactionlistener.UpdateActionListener.processAction(UpdateActionListener.java:137)
at javax.faces.event.ActionEvent.processListener(ActionEvent.java:51)
at javax.faces.component.UIComponentBase.broadcast(UIComponentBase.java:554)
at javax.faces.component.UICommand.broadcast(UICommand.java:110)
at javax.faces.component.UIData.broadcast(UIData.java:721)
at org.ajax4jsf.component.AjaxViewRoot.processEvents(AjaxViewRoot.java:324)
at org.ajax4jsf.component.AjaxViewRoot.broadcastEvents(AjaxViewRoot.java:299)
at org.ajax4jsf.component.AjaxViewRoot.processPhase(AjaxViewRoot.java:256)
at org.ajax4jsf.component.AjaxViewRoot.processDecodes(AjaxViewRoot.java:412)
at org.apache.myfaces.lifecycle.ApplyRequestValuesExecutor.execute(ApplyRequestValuesExecutor.java:32)
at org.apache.myfaces.lifecycle.LifecycleImpl.executePhase(LifecycleImpl.java:103)
at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:76)
at org.apache.myfaces.custom.ppr.PPRLifecycleWrapper.execute(PPRLifecycleWrapper.java:68)
at javax.faces.webapp.FacesServlet.service(FacesServlet.java:178)
at com.recommind.xxx.servlets.FacesServletWrapper.service(FacesServletWrapper.java:123)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:178)
at org.ajax4jsf.webapp.BaseFilter.handleRequest(BaseFilter.java:290)
at org.ajax4jsf.webapp.BaseFilter.processUploadsAndHandleRequest(BaseFilter.java:388)
at org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:515)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.myfaces.webapp.filter.ExtensionsFilter.doFilter(ExtensionsFilter.java:384)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at com.recommind.xxx.filters.LoginFilter.doFilter(LoginFilter.java:193)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at com.recommind.xxx.client.web.filters.EncodingFilter.doFilter(EncodingFilter.java:49)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at com.recommind.xxx.filters.TimerFilter.doFilter(TimerFilter.java:71)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:433)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:286)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:845)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583)
at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:447)
at java.lang.Thread.run(Thread.java:619)

Sample jsp snippet:
<t:dataList var="batch"
value="#

{MyController1.myList}

" ...>
<t:commandButton id="batchSelectCmd" forceId="true"
immediate="true"
action="#

{MyController12.search}

"
value="foo"
disabled="#

{empty batch.attributes['reviewState'][0]}

"
... >
<t:updateActionListener property="#

{requestScope['selectedBatch']}

" value="#

{batch.value}

"/>
</t:commandButton>
</t:dataList>

Commands are working with the 1.1 compliant libs.
Commands are working without t:updateActionListener.

A similar issue is MYFACES-1819 "h:selectManyCheckbox with value="#

{bean.map['somekey']}" fails"

A workaround is to replace updateActionListener by setPropertyActionListener (Thanks to Mike Kienenberger).

Copied from the corresponding email thread on the dev list from Leonardo Uribe:
"In few words the problem is that in EL, expressions like "#{bean.map['somekey']}

" returns null when getType() is called. Note this does not happens in jsf 1.1, but on jsf 1.2.
Checking the code of f:setPropertyActionListener, it just do a simple call like this:

target.setValue(ectx, value.getValue(ectx));

But t:updateActionListener has an additional converter property, so it try to use the converter before call setValue."

Discussion in user list.
http://marc.info/?l=myfaces-user&m=126089767620528&w=2