[TOMAHAWK-1448] InputHtmlRenderer: Missing xmlns:i18n declarations in various HTML elements

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.9
• Fix Version/s: 1.1.10
• Component/s: Html Editor
• Assignee: Leonardo Uribe
• Reporter: Lutz Ulruch
• Created: 18/Sep/09 13:27
• Updated: 27/Sep/10 21:36
• Resolved: 28/Mar/10 22:30

Description

In encodeEndNormalMode() various HTML elements are written with attributes prefixed with "i18n".
Not all those HTML elements have a namespace definition.
That is:

writer.writeAttribute("xmlns:i18n", "http://xml.zope.org/namespaces/i18n", null);

is missing for various elements (whereas for most elements the namespace attribute is set already).

This results in invalid XHTML. This in turn results in errors with DOM parsing throug browser-side scripts, like with RichFaces' PPR.
Please, just add the missing xmlns:i18n attributes.

Suggestion: Put the xmlns attributes in parent HTML elements instead of reproducing them all the child elements. This would save HTML code.
For example:
<div xmlns:i18n="http://xml.zope.org/namespaces/i18n" id="toolbar" class="kupu-tb">
...
<button i18n:attributes="title"/> // no need to repeat xmlns-attribute because it is now in the parent div

There are just 2 div elements which need the xmlns:i18n attribute:
<div id="toolbar" > and <div id="kupu-toolboxes">

Issue Links

• is part of: TOMAHAWK-1498 Update t:inputHtml and kupu to 1.4.16