[TOMAHAWK-1391] Inserting <!-- MYFACES JAVASCRIPT --> into HTML output is potential security problem

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1.8
• Fix Version/s: 1.1.9
• Component/s: ExtensionsFilter
• Assignee: Leonardo Uribe
• Reporter: Kennard Consulting
• Created: 11/Feb/09 01:38
• Updated: 16/Jun/09 01:35
• Resolved: 27/May/09 01:15

Description

A recommended practice to security 'hardening' a Web site is to divulge as little architectual information as possible. For example, we suppress the X-Server HTTP header so you don't know what server we are using. We map '*.jsf' to something else so you can't tell we're using JSF.

However, one giveaway is that in org.apache.myfaces.renderkit.html.util.ExtensionsPhaseListener.java, method getCodeBeforeBodyEnd(), around line 111, there is the line:

return "<!-- MYFACES JAVASCRIPT -->\n"writerWrapper.toString()"\n";

This always outputs 'MYFACES' into the HTML whenever the ExtensionsPhaseListener is used (even if there is no actual JavaScript being output). I would like to see this line change to simply...

return writerWrapper.toString();

Which would not give away we are using JSF.