[TOMAHAWK-1384] XML Parsing Error in Firefox 2.x when using Tomahawk Schedule with Facelets

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.1.7, 1.1.8
• Fix Version/s: 1.1.9
• Component/s: Schedule
• Environment: JBoss - 4.2.2 GA ; Seam - 2.0.2.SP1; Facelets - 1.1.14; Tomahawk 1.1.7 or 1.1.8
• Assignee: Peter Mahoney
• Reporter: Dan Stoica
• Created: 06/Jan/09 01:53
• Updated: 16/Jun/09 01:35
• Resolved: 06/Jan/09 08:10

Description

Using Firefox 2.x the flowing error occurs:
"XML Parsing Error: mismatched tag. Expected: </tr>."

For Firefox 3.x or IE 7 the Schedule component works with no problems even for facelets.
Also there are no problems for Firefox2.0 when using Schedule in a JSP page (no facelets).

The source of the error is a <TR> tag not closed inside the ScheduleDetailedDayRenderer class.
In the writeGutter method the last writer.endElement(HTML.TR_ELEM) should be inside the "while" block.

protected void writeGutter(FacesContext context, HtmlSchedule schedule,
ResponseWriter writer, boolean useIntervalLabels) throws IOException
{
boolean renderGutter = true;

while (intervalIt.hasNext())

{ ....... writer.endElement(HTML.TR_ELEM); }

// writer.endElement(HTML.TR_ELEM);
writer.endElement(HTML.TBODY_ELEM);
writer.endElement(HTML.TABLE_ELEM);
}