[TOMAHAWK-1381] HtmlInputFileUpload does not fail gracefully when filesize exceeds uploadMaxFileSize web.xml value

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.7, 1.1.8
• Fix Version/s: 1.1.9
• Component/s: File Upload
• Assignee: Leonardo Uribe
• Reporter: Phillip Webb
• Created: 11/Dec/08 18:19
• Updated: 12/Oct/11 10:02
• Resolved: 08/Jun/09 03:30

Description

When uploading a file using the HtmlInputFileUpload that exceeds that uploadMaxFileSize web.xml setting the system fails without error and no form data is not processed by JSF.

I think that there are a number of reasons for this:

• There is a bug in commons-fileupload that prevents failures from being handled correctly (see FILEUPLOAD-169)
• MultipartRequestWrapper calls FileUploads setSizeMax, this is the size for the total upload, and not individual files, it should call setFileSizeMax
• HtmlFileUploadRenderer calls fileUpload.parseRequest(request), this will fail if any size exceptions are thrown, it would be better to use fileUpload.getItemIterator and catch each exception.

Issue Links

• incorporates: TOMAHAWK-1420 uploadThresholdSize seems to be ignored
• is duplicated by: TOMAHAWK-1305 No error when file is uploaded larger than uploadMaxFileSize