[TOMAHAWK-1058] DataScroller html rendering bug: duplicate td element for paginator

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 1.1.6
• Component/s: Data Scroller
• Assignee: Leonardo Uribe
• Reporter: Chinh Nguyen
• Created: 19/Jul/07 03:05
• Updated: 24/Jun/08 22:06
• Resolved: 24/Jun/08 22:06

Description

In the default layout mode (table), the paginator is rendered inside a <td> tag. The result is that a td element is rendered inside another td element, which is invalid HTML code:

[code]
<td><td style="font-weight:bold;"><a href="#" onclick="return oamSubmitForm('_idJsp0','_idJsp0:scroll_1idx1',null,[['_idJsp0:scroll_1','idx1']]);" id="_idJsp0:scroll_1idx1">1</a></td>...<td><a href="#" onclick="return oamSubmitForm('_idJsp0','_idJsp0:scroll_1idx9',null,[['_idJsp0:scroll_1','idx9']]);" id="_idJsp0:scroll_1idx9">9</a></td></td><td>
[/code]

Fix:
Line 258-263 of HtmlDataScrollerRenderer.java:

[code]
if (scroller.isPaginator())
{
writeScrollerElementStart(writer, scroller);
renderPaginator(facesContext, scroller);
writeScrollerElementEnd(writer, scroller);
}
[/code]

change to:

[code]
if (scroller.isPaginator())
{
if (scroller.isListLayout()) writeScrollerElementStart(writer, scroller);
renderPaginator(facesContext, scroller);
if (scroller.isListLayout()) writeScrollerElementEnd(writer, scroller);
}
[/code]