Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-990

Mixed types in VertexPropertyTest

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.0.2-incubating
    • 3.1.1-incubating
    • test-suite
    • None

    Description

      shouldRemoveMultiPropertiesWhenVerticesAreRemoved of VertexPropertyTest.VertexPropertyRemoval mixes types. The test uses String data types for "name" but then also adds integers. In systems with a strict typesystem, those integers would get converted to Strings which makes the subsequent removal test fail which checks for integer.class.

      Such mixing of types should be avoided in TinkerPop tests.

      This can furthermore be found in the following test cases:

      • AddEdgeTest#g_VX1X_asXaX_outXcreatedX_addOutEXcreatedBy_a_weight_2X (mixed double with integer for "weight")
      • AddEdgeTest#g_VX1X_asXaX_outXcreatedX_addEXcreatedByX_toXaX_propertyXweight_2X (mixed double with integer for "weight")

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            spmallette Stephen Mallette
            mbroecheler Matthias Broecheler
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment