Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.2-incubating
    • Fix Version/s: 3.1.1-incubating
    • Component/s: test-suite
    • Labels:
      None

      Description

      shouldRemoveMultiPropertiesWhenVerticesAreRemoved of VertexPropertyTest.VertexPropertyRemoval mixes types. The test uses String data types for "name" but then also adds integers. In systems with a strict typesystem, those integers would get converted to Strings which makes the subsequent removal test fail which checks for integer.class.

      Such mixing of types should be avoided in TinkerPop tests.

      This can furthermore be found in the following test cases:

      • AddEdgeTest#g_VX1X_asXaX_outXcreatedX_addOutEXcreatedBy_a_weight_2X (mixed double with integer for "weight")
      • AddEdgeTest#g_VX1X_asXaX_outXcreatedX_addEXcreatedByX_toXaX_propertyXweight_2X (mixed double with integer for "weight")

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user n-tran opened a pull request:

        https://github.com/apache/incubator-tinkerpop/pull/156

        TINKERPOP3-990 Removed mixed typing in VertexPropertyTest

        Converted integer value to string to maintain type

        https://issues.apache.org/jira/browse/TINKERPOP3-990

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/n-tran/incubator-tinkerpop TINKERPOP3-990

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-tinkerpop/pull/156.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #156


        commit fd95dc8b62c02f73c9de8da31fb7a200efe2929a
        Author: Nghia Tran <nghia.tran.83@gmail.com>
        Date: 2015-11-25T00:53:45Z

        Removed mixed typing in VertexPropertyTest

        Converted integer value to string to maintain type


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user n-tran opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/156 TINKERPOP3-990 Removed mixed typing in VertexPropertyTest Converted integer value to string to maintain type https://issues.apache.org/jira/browse/TINKERPOP3-990 You can merge this pull request into a Git repository by running: $ git pull https://github.com/n-tran/incubator-tinkerpop TINKERPOP3-990 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #156 commit fd95dc8b62c02f73c9de8da31fb7a200efe2929a Author: Nghia Tran <nghia.tran.83@gmail.com> Date: 2015-11-25T00:53:45Z Removed mixed typing in VertexPropertyTest Converted integer value to string to maintain type
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-159551463

        Thanks for this. Note that since you submitted this PR, there are two other tests that have been identified to have this problem (see JIRA). Can you please amend your PR to include those fixes?

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-159551463 Thanks for this. Note that since you submitted this PR, there are two other tests that have been identified to have this problem (see JIRA). Can you please amend your PR to include those fixes?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user n-tran commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160213406

        Fixed the two tests, ready for review

        Show
        githubbot ASF GitHub Bot added a comment - Github user n-tran commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160213406 Fixed the two tests, ready for review
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user PommeVerte commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160421306

        This is straightforward enough. Don't know if this needs to go through RTC but just incase:

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user PommeVerte commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160421306 This is straightforward enough. Don't know if this needs to go through RTC but just incase: VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160421522

        VOTE +1.

        This is consistent with `weight` being used as `Double` in `MODERN`.

        ```
        gremlin> g.E().values('weight').limit(1).map

        {it.get().getClass()}

        ==>class java.lang.Double
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160421522 VOTE +1. This is consistent with `weight` being used as `Double` in `MODERN`. ``` gremlin> g.E().values('weight').limit(1).map {it.get().getClass()} ==>class java.lang.Double ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160652369

        VOTE +1 - about to merge

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160652369 VOTE +1 - about to merge
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/156

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/156

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            mbroecheler Matthias Broecheler
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development