Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-926

Renamed TinkerGraph public statics to common pattern used for other statics.

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 3.0.2-incubating
        • Fix Version/s: 3.1.0-incubating
        • Component/s: tinkergraph
        • Labels:
          None

          Description

          These are bad. stephen mallette Verify this isn't backwards compatible and I will fix it.

              public static final String CONFIG_VERTEX_ID = "gremlin.tinkergraph.vertexIdManager";
    public static final String CONFIG_EDGE_ID = "gremlin.tinkergraph.edgeIdManager";
    public static final String CONFIG_VERTEX_PROPERTY_ID = "gremlin.tinkergraph.vertexPropertyIdManager";
    public static final String CONFIG_DEFAULT_VERTEX_PROPERTY_CARDINALITY = "gremlin.tinkergraph.defaultVertexPropertyCardinality";
    public static final String CONFIG_GRAPH_LOCATION = "gremlin.tinkergraph.graphLocation";
    public static final String CONFIG_GRAPH_FORMAT = "gremlin.tinkergraph.graphFormat";

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            GitHub user okram opened a pull request:

            https://github.com/apache/incubator-tinkerpop/pull/123

            TINKERPOP3-926: Renamed TinkerGraph public statics to common pattern used for other statics.

            https://issues.apache.org/jira/browse/TINKERPOP3-926

            Renamed the `public statics` to use the standard TinkerPop pattern of spelling out the full property name is capital case with new words (and or camel case) having a `_` split.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-926

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/incubator-tinkerpop/pull/123.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #123

            commit 12de257cb43ea13b768ead04ce2a63108b608c8a
            Author: Marko A. Rodriguez <okrammarko@gmail.com>
            Date: 2015-10-27T23:35:00Z

            Fixed the .properties file keys consistent with TinkerPop pattern.

            Show
            githubbot ASF GitHub Bot added a comment - GitHub user okram opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/123 TINKERPOP3-926 : Renamed TinkerGraph public statics to common pattern used for other statics. https://issues.apache.org/jira/browse/TINKERPOP3-926 Renamed the `public statics` to use the standard TinkerPop pattern of spelling out the full property name is capital case with new words (and or camel case) having a `_` split. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-926 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/123.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #123 commit 12de257cb43ea13b768ead04ce2a63108b608c8a Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2015-10-27T23:35:00Z Fixed the .properties file keys consistent with TinkerPop pattern.
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user okram commented on the pull request:

            https://github.com/apache/incubator-tinkerpop/pull/123#issuecomment-151675798

            And, yes, I VOTE +1.

            Show
            githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/123#issuecomment-151675798 And, yes, I VOTE +1.
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user spmallette commented on the pull request:

            https://github.com/apache/incubator-tinkerpop/pull/123#issuecomment-151685440

            +1 - ran `mvn clean install` - all good.

            Show
            githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/123#issuecomment-151685440 +1 - ran `mvn clean install` - all good.
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user pluradj commented on the pull request:

            https://github.com/apache/incubator-tinkerpop/pull/123#issuecomment-151714709

            +1 Ran `mvn clean install` successfully. Appreciate the trailing whitespace cleanup too. Looks good to me.

            Show
            githubbot ASF GitHub Bot added a comment - Github user pluradj commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/123#issuecomment-151714709 +1 Ran `mvn clean install` successfully. Appreciate the trailing whitespace cleanup too. Looks good to me.
            Hide
            Permalink
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/incubator-tinkerpop/pull/123

            Show
            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/123

              People

              • Assignee:
                okram Marko A. Rodriguez
                Reporter:
                okram Marko A. Rodriguez
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development