Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: 3.0.2-incubating
    • Fix Version/s: 3.1.1-incubating
    • Component/s: groovy
    • Labels:
      None

      Description

      The sandboxing abstractions are not so good a set of building blocks as I'd once thought. Helper methods aren't in the right places and more flexibilty is required in managing methods/variables than just simple filters. Need to develop more concrete actions on this still.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user spmallette opened a pull request:

        https://github.com/apache/incubator-tinkerpop/pull/179

        TINKERPOP-891 Refactored the sandboxing abstractions for Gremlin Server

        https://issues.apache.org/jira/browse/TINKERPOP-891

        Deprecated the `SandboxExtension` and replaced it with the `AbstractSandboxExtension`. Took existing implementations and had them extend from the new `AbstractSandboxExtension`. Added a new "useful" implementation called `FileSandboxExtension` which gets its white list configuration from a file. Updated appropriate docs and wrote a number of tests for the new `FileSandboxExtension`.

        Both unit and integration tests pass. Also tested manually by configuring Gremlin Server to use the different sandboxes.

        VOTE: +1

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-891

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-tinkerpop/pull/179.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #179


        commit a15b646ade8a106495dbbe29ba803218445bb20e
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-11T19:56:06Z

        Refactored the sandboxing abstractions for Gremlin Server.

        Deprecated the SandboxExtension and replaced it with the AbstractSandboxExtension. Took existing implementations and had them extend from the new AbstractSandboxExtension. Added a new "useful" implementation called FileSandboxExtension which gets its white list configuration from a file. Updated appropriate docs and wrote a number of tests for the new FileSandboxExtension.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/179 TINKERPOP-891 Refactored the sandboxing abstractions for Gremlin Server https://issues.apache.org/jira/browse/TINKERPOP-891 Deprecated the `SandboxExtension` and replaced it with the `AbstractSandboxExtension`. Took existing implementations and had them extend from the new `AbstractSandboxExtension`. Added a new "useful" implementation called `FileSandboxExtension` which gets its white list configuration from a file. Updated appropriate docs and wrote a number of tests for the new `FileSandboxExtension`. Both unit and integration tests pass. Also tested manually by configuring Gremlin Server to use the different sandboxes. VOTE: +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-891 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/179.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #179 commit a15b646ade8a106495dbbe29ba803218445bb20e Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-11T19:56:06Z Refactored the sandboxing abstractions for Gremlin Server. Deprecated the SandboxExtension and replaced it with the AbstractSandboxExtension. Took existing implementations and had them extend from the new AbstractSandboxExtension. Added a new "useful" implementation called FileSandboxExtension which gets its white list configuration from a file. Updated appropriate docs and wrote a number of tests for the new FileSandboxExtension.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user twilmes commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/179#issuecomment-164474080

        Looks good.

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user twilmes commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/179#issuecomment-164474080 Looks good. VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/179#issuecomment-164529984

        • `mvn clean install`: worked
        • integration tests: worked

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/179#issuecomment-164529984 `mvn clean install`: worked integration tests: worked VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/179

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/179

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            spmallette stephen mallette
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development