Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-880

Remove deprecated GroupStepV3d0 and GroupSideEffectStepV3d0

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.2-incubating
    • Fix Version/s: 3.3.0
    • Component/s: process
    • Labels:

      Description

      There are also numerous test cases that reference these classes. Once the steps are removed the chain of dependencies will make themselves apparent.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/661

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/661
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/661

          VOTE +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/661 VOTE +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/661

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/661 VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user okram opened a pull request:

          https://github.com/apache/tinkerpop/pull/661

          TINKERPOP-880: Remove deprecated GroupStepV3d0 and GroupSideEffectStepV3d0

          https://issues.apache.org/jira/browse/TINKERPOP-880

          `groupV3d0()` was created for backward compatibility prior to having the new "running reducer" with only two `by()`-modulations in modern `group()`. It has been a pain having to deal with this "fork" of the step in terms of testing (especially in the complicated arena of OLAP). As such, removing this deprecation will make life easier.

          VOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-880

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/661.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #661


          commit 05ed3c29396d6742e731b8edc137371e96d401dc
          Author: Marko A. Rodriguez <okrammarko@gmail.com>
          Date: 2017-07-10T16:15:11Z

          removed deprecated groupV3d0() step and its associated test cases and support classes.

          commit 99d38d4a484ea2600d1bf7e1ec45f4f415407e07
          Author: Marko A. Rodriguez <okrammarko@gmail.com>
          Date: 2017-07-10T16:26:54Z

          fixed a bug in release docs. TinkerGraphPlay test had groupV3d0() references. Also, new graph_traversal.py created accordingly.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/661 TINKERPOP-880 : Remove deprecated GroupStepV3d0 and GroupSideEffectStepV3d0 https://issues.apache.org/jira/browse/TINKERPOP-880 `groupV3d0()` was created for backward compatibility prior to having the new "running reducer" with only two `by()`-modulations in modern `group()`. It has been a pain having to deal with this "fork" of the step in terms of testing (especially in the complicated arena of OLAP). As such, removing this deprecation will make life easier. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-880 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/661.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #661 commit 05ed3c29396d6742e731b8edc137371e96d401dc Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2017-07-10T16:15:11Z removed deprecated groupV3d0() step and its associated test cases and support classes. commit 99d38d4a484ea2600d1bf7e1ec45f4f415407e07 Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2017-07-10T16:26:54Z fixed a bug in release docs. TinkerGraphPlay test had groupV3d0() references. Also, new graph_traversal.py created accordingly.

            People

            • Assignee:
              okram Marko A. Rodriguez
              Reporter:
              okram Marko A. Rodriguez
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development