Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-859

Provide a more general way to set log levels in plugins

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: 3.0.2-incubating
    • Fix Version/s: 3.1.1-incubating
    • Component/s: plugin
    • Labels:
      None

      Description

      Currently plugins are bound to log4j which allow the log level to be set programmatically from the plugin itself. It would be better if this could be set some other way from the plugin as we've gone through the trouble of using slf4j as an abstraction for logging.

      This might be helpful: http://stackoverflow.com/questions/10505418/how-to-find-which-library-slf4j-has-bound-itself-to

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/incubator-tinkerpop/pull/171

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tinkerpop/pull/171
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-163305727

        • `mvn clean install` worked
        • logging in the console still looks good to me

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-163305727 `mvn clean install` worked logging in the console still looks good to me VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-163198300

        Looks like i have a branch conflict on the upgrade docs. Easy enough to fix. Still need a vote to get this merged back.

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-163198300 Looks like i have a branch conflict on the upgrade docs. Easy enough to fix. Still need a vote to get this merged back.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user ds-jenkins-builds commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-162859139

        Build finished. No test results found.

        Show
        githubbot ASF GitHub Bot added a comment - Github user ds-jenkins-builds commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-162859139 Build finished. No test results found.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-162620851

        i was semi-clueless too until just recently with that travis work.

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-162620851 i was semi-clueless too until just recently with that travis work.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the pull request:

        https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-162617085

        Thanks @spmallette – I'm clueless when it comes to Logging in Java. Thanks for tiddying up my work.

        VOTE +1.

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/171#issuecomment-162617085 Thanks @spmallette – I'm clueless when it comes to Logging in Java. Thanks for tiddying up my work. VOTE +1.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user spmallette opened a pull request:

        https://github.com/apache/incubator-tinkerpop/pull/171

        TINKERPOP-859 Moved logging setup to configuration in HadoopGremlinPlugin

        https://issues.apache.org/jira/browse/TINKERPOP-859

        Logging setup shouldn't be hardcoded anywhere especially since we use slf4j. With this approach the user has the ultimate control over what they want logged and what they don't. TinkerPop provides a sensible default in the provided logging properties files using log4j.

        I tested the console manually copying the examples in the reference documentation after these changes and didn't see any difference in the output to the console.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-859

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/incubator-tinkerpop/pull/171.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #171


        commit b9efcb6a99bf83e94f8db6a4612f0d92c23526cd
        Author: Stephen Mallette <spmva@genoprime.com>
        Date: 2015-12-07T16:29:49Z

        Moved logging setup to configuration.

        Logging setup shouldn't be hardcoded anywhere especially since we use slf4j. With this approach the user has the ultimate control over what they want logged and what they don't. TinkerPop provides a sensible default in the provided logging properties files using log4j.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/171 TINKERPOP-859 Moved logging setup to configuration in HadoopGremlinPlugin https://issues.apache.org/jira/browse/TINKERPOP-859 Logging setup shouldn't be hardcoded anywhere especially since we use slf4j. With this approach the user has the ultimate control over what they want logged and what they don't. TinkerPop provides a sensible default in the provided logging properties files using log4j. I tested the console manually copying the examples in the reference documentation after these changes and didn't see any difference in the output to the console. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-859 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/171.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #171 commit b9efcb6a99bf83e94f8db6a4612f0d92c23526cd Author: Stephen Mallette <spmva@genoprime.com> Date: 2015-12-07T16:29:49Z Moved logging setup to configuration. Logging setup shouldn't be hardcoded anywhere especially since we use slf4j. With this approach the user has the ultimate control over what they want logged and what they don't. TinkerPop provides a sensible default in the provided logging properties files using log4j.

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            spmallette stephen mallette
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development