Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-832

Remove deprecated addV/E/InE/OutE methods

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.2-incubating
    • Fix Version/s: 3.3.0
    • Component/s: process
    • Labels:

      Description

      The related methods are on GraphTraversal, __ and GraphTraversalSource. It should be noted that these are public methods likely utilized by end-users.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user okram opened a pull request:

          https://github.com/apache/tinkerpop/pull/657

          TINKERPOP-832: Remove deprecated addV/E/InE/OutE methods

          https://issues.apache.org/jira/browse/TINKERPOP-832

          Removed deprecated `addV()`, `addE()`, `addInE()`, and `addOutE()` methods that are no longer supported given the introduction of the `to()` and `from()` modulators. This is actually a very good deprecation to remove as there is a lot of extraneous testing (and bug proneness) around these methods given the complicated interactions with the desired overloaded methods of the same name – lots of parameter type checking and validation (gross).

          VOTE +1.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-832

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/657.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #657


          commit 1e034535b0bc896beff497ed9473fcfa8b70e876
          Author: Marko A. Rodriguez <okrammarko@gmail.com>
          Date: 2017-07-10T14:14:54Z

          Removed ancient deprecated mutation steps of addV(), addE(), and addOutE(), addInE(). These are no longer needed given the introduction of to() and from() constructs.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/657 TINKERPOP-832 : Remove deprecated addV/E/InE/OutE methods https://issues.apache.org/jira/browse/TINKERPOP-832 Removed deprecated `addV()`, `addE()`, `addInE()`, and `addOutE()` methods that are no longer supported given the introduction of the `to()` and `from()` modulators. This is actually a very good deprecation to remove as there is a lot of extraneous testing (and bug proneness) around these methods given the complicated interactions with the desired overloaded methods of the same name – lots of parameter type checking and validation (gross). VOTE +1. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-832 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/657.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #657 commit 1e034535b0bc896beff497ed9473fcfa8b70e876 Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2017-07-10T14:14:54Z Removed ancient deprecated mutation steps of addV(), addE(), and addOutE(), addInE(). These are no longer needed given the introduction of to() and from() constructs.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on a diff in the pull request:

          https://github.com/apache/tinkerpop/pull/657#discussion_r126479090

          — Diff: docs/src/upgrade/release-3.3.x.asciidoc —
          @@ -211,6 +211,10 @@ The following deprecated classes, methods or fields have been removed in this ve

            • `org.apache.tinkerpop.gremlin.process.traversal.util.OrP(P...)`
            • `org.apache.tinkerpop.gremlin.process.traversal.util.TraversalScriptFunction`
            • `org.apache.tinkerpop.gremlin.process.traversal.util.TraversalScriptHelper`
              +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addV(Object...)`
              +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addE(Direction, String, String, Object...)`
              +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addOutE(String, String, Object...)`
              +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addInV(String, String, Object...)`
              • End diff –

          can you please reference the ticket further on down below? you might need to do the same on your other PRs - didn't look yet.

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/657#discussion_r126479090 — Diff: docs/src/upgrade/release-3.3.x.asciidoc — @@ -211,6 +211,10 @@ The following deprecated classes, methods or fields have been removed in this ve `org.apache.tinkerpop.gremlin.process.traversal.util.OrP(P...)` `org.apache.tinkerpop.gremlin.process.traversal.util.TraversalScriptFunction` `org.apache.tinkerpop.gremlin.process.traversal.util.TraversalScriptHelper` +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addV(Object...)` +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addE(Direction, String, String, Object...)` +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addOutE(String, String, Object...)` +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addInV(String, String, Object...)` End diff – can you please reference the ticket further on down below? you might need to do the same on your other PRs - didn't look yet.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user okram commented on the issue:

          https://github.com/apache/tinkerpop/pull/657

          I haven't done any of that for any of the deprecation tickets. Once these are all merged, I will do a CTR of everything since then.

          Show
          githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/657 I haven't done any of that for any of the deprecation tickets. Once these are all merged, I will do a CTR of everything since then.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/657

          ok - fyi, i already cleaned up past ones (i'd forgotten to notice that when i +1d your other deprecation removals) you'd only have to do it for these new ones.

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/657 ok - fyi, i already cleaned up past ones (i'd forgotten to notice that when i +1d your other deprecation removals) you'd only have to do it for these new ones.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/657

          Full build failed in Gremlin Server integration tests. See `GremlinDriverIntegrateTest` for two failures and two errors - must be some usage of the removed methods in there somewhere embedded in strings.

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/657 Full build failed in Gremlin Server integration tests. See `GremlinDriverIntegrateTest` for two failures and two errors - must be some usage of the removed methods in there somewhere embedded in strings.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/657

          `docker/build.sh -t -i` succeeded.

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/657 `docker/build.sh -t -i` succeeded. VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/657

          All tests pass with `docker/build.sh -t -n -i`

          VOTE +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/657 All tests pass with `docker/build.sh -t -n -i` VOTE +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/657

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/657

            People

            • Assignee:
              okram Marko A. Rodriguez
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development