Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-756

Provide a strict parsing option for GraphMLReader

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: 3.0.0-incubating
    • Fix Version/s: 3.1.0-incubating
    • Component/s: io
    • Labels:
      None

      Description

      Opening this per the request of Stephen M. over on the gremlin users forum.

      https://groups.google.com/forum/#!topic/gremlin-users/jHFE7Isk61E

      If the type of a value in a GraphML file is specified as Double but the file contains an empty string in that element, a rather misleading exception is thrown that does not make it clear the XML file is the problem during the loading of the XML using the GraphML reader.

      Stephen and I discussed a bit whether the exception text should just be improved or if the behavior should be changed (ie continue loading but issue a warning etc.)

      As a side note, other GraphML implementations I tried, like Gephi, handle my XML file differently. Gephi loads the file and just does not assign any value to the properties that contain empty strings. That's not to say Gephi is right more observing this seems to be an area that is handled inconsistently across GraphML readers.

        Activity

        Hide
        spmallette stephen mallette added a comment -

        GraphMLReader now has a strict option on the Builder so that if a data type for a value is invalidate in some way, GraphMLReader will simply skip that problem value. In that way, it is a bit more forgiving than before especially with empty data.

        Implemented via:

        https://github.com/apache/incubator-tinkerpop/commit/45023be9d71e565338da44aa7dbbbbd6708d2afb

        Show
        spmallette stephen mallette added a comment - GraphMLReader now has a strict option on the Builder so that if a data type for a value is invalidate in some way, GraphMLReader will simply skip that problem value. In that way, it is a bit more forgiving than before especially with empty data. Implemented via: https://github.com/apache/incubator-tinkerpop/commit/45023be9d71e565338da44aa7dbbbbd6708d2afb

          People

          • Assignee:
            spmallette stephen mallette
            Reporter:
            gfxman Kelvin R. Lawrence
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development