[TINKERPOP-750] Compare should not have special case for Number

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Implemented
• Affects Version/s: 3.0.0-incubating
• Fix Version/s: 3.0.1-incubating, 3.1.0-incubating
• Component/s: process
• Assignee: Matt Frantz
• Reporter: Matt Frantz
• Created: 27/Jun/15 18:07
• Updated: 01/Sep/15 13:29
• Resolved: 01/Sep/15 13:29

Description

The current implementation of Compare has a special case for Number which uses doubleValue for all comparisons. However, this fails for some implementations of Number, e.g. BigInteger. Also, most implementations of Number implement Comparable for appropriately typed arguments. It should be more robust and less surprising to simply use Object.equals and Comparable.compareTo. This would also be more performant as it removes the instanceof checks.

If we want the option of treating all numbers as doubles, perhaps something called CompareDouble would be more appropriate.