[TINKERPOP-3077] Javascript translator incorrectly handle quotes, null and undefined values

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.6.7, 3.7.2
• Fix Version/s: 3.6.8, 3.7.3
• Component/s: javascript
• Assignee: Cole Greer
• Reporter: Valentyn Kahamlyk
• Created: 30/Apr/24 16:33
• Updated: 16/Oct/24 20:10
• Resolved: 16/Oct/24 20:10

Description

If there are `null` or `undefined` values in queries, the translator converts them incorrectly. `null` converted as string "null" and `undefined`  is simply skipped.
Quotes are not properly escaped
Simple reproducer.

const script1 = new Translator('g')
    .translate(g.addV('test').property('empty', null).getBytecode());
console.log(script1);

const script2 = new Translator('g')
    .translate(g.addV('test').property('empty', undefined).getBytecode());
console.log(script2);

const script3 = new Translator('g')
    .translate(g.addV('test').property('quotes', "some \"quotes' in the middle.").getBytecode());
console.log(script3);

 

output:

g.addV('test').property('empty', 'null')
g.addV('test').property('empty', )
g.addV('test').property('quotes', 'some "quotes' in the middle.')

which results in a server error when submitting translated query.