Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2938

Revisit merge step feature tests

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 3.6.2
    • 3.7.0, 3.6.5
    • process
    • None

    Description

      I've added a set of tests for https://github.com/apache/tinkerpop/pull/2036, with the CTR here https://github.com/apache/tinkerpop/commit/2c9e5300d6901c72e565f89e50ab0e4844ccd56e

      Ideally I want the Feature test to check that the exception fails with the intended error message, however, there seems to be a problem with the exception falling through when you have an empty graph and invalid maps to add just to g.V(['~label', vertex]). The intended errors appear to be null when you check with the step, but then gets printed after in the terminal output, which I wonder if it's not being caught in the toList() step, or if there is some race going on.

      Attachments

        Activity

          People

            xiazcy Yang Xia
            xiazcy Yang Xia
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: