[TINKERPOP-2565] GraphMLWriter does not check vertexLabelKey conflict

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.11
• Fix Version/s: 3.4.12, 3.5.1, 3.6.0
• Component/s: io
• Assignee: Stephen Mallette
• Reporter: Luz
• Created: 13/May/21 18:00
• Updated: 02/Jun/21 12:31
• Resolved: 02/Jun/21 12:31

Description

Reading the GraphMLWriter code I came across these weird lines of code:

if (identifiedEdgeKeyTypes.containsKey(this.edgeLabelKey))
   throw new IllegalStateException(String.format("The edgeLabelKey value of[%s] conflicts with the name of an existing property key to be included in the GraphML", this.edgeLabelKey));
if (identifiedEdgeKeyTypes.containsKey(this.edgeLabelKey))
   throw new IllegalStateException(String.format("The vertexLabelKey value of[%s] conflicts with the name of an existing property key to be included in the GraphML", this.vertexLabelKey));

The check is identical, but the exception is different?
This smells like a copy-paste errors and the second check should be more like:

if (identifiedVertexKeyTypes.containsKey(this.vertexLabelKey))