[TINKERPOP-2262] Improve Netty protocol handling

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Done
• Affects Version/s: 3.3.7, 3.4.2
• Fix Version/s: 3.5.0, 3.4.5
• Component/s: driver, server
• Assignee: Stephen Mallette
• Reporter: Divij Vaidya
• Created: 10/Jul/19 20:51
• Updated: 02/Jan/20 17:07
• Resolved: 02/Jan/20 17:07

Description

4.1.37 adds https://github.com/netty/netty/pull/9116 which is critical to the stability of the Java Client.

After the upgrade a follow-up task would :
1. change the Java Client to set the newly introduced flag  "closeOnProtocolViolation" to false. This would prevent causing all the other requests using the same channel to fail when a single request causes a protocol violation.
2. introduce the protocol exception error handling code on the client to handle protocol violation exceptions. Currently, the code force replaces the channel, thus closing all the other requests being served on the channel.[

https://netty.io/news/2019/06/28/4-1-37-Final.html]

Issue Links

• links to: GitHub Pull Request #1232