[TINKERPOP-2253] Special case for JToken in SubmitAsync()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 3.4.0
• Component/s: dotnet
• External issue URL: https://github.com/evo-terren/Gremlin.Net.CosmosDb/issues/49
• Assignee: Unassigned
• Reporter: Sam Hard
• Created: 03/Jul/19 04:12
• Updated: 11/Nov/20 14:54
• Resolved: 11/Nov/20 14:54

Description

A recent change to Gremlin.Net, made to address TINKERPOP-2067, broke existing functionality for the downstream library Gremlin.Net.CosmosDb.  That library invokes Gremlin.Net.Driver.Connection's `SubmitAsync<T>()` method, sending `JToken` as the generic type argument, and expects the query results to be run through `_graphSONReader.ToObject()`, but that step is now specifically skipped just for `JToken`.

I propose that it would be better for Connection.SubmitAsync() to work the same for all types, as it did before, and that a new property in the class (or an optional method parameter) could be used to configure when the graphSON reader should be bypassed.

The breaking change was merged with this pull request:  https://github.com/apache/tinkerpop/pull/972

As a cross-reference, the GitHub issue documenting the problem with Gremlin.Net.CosmosDb can be found here: https://github.com/evo-terren/Gremlin.Net.CosmosDb/issues/49

Issue Links

• is caused by: TINKERPOP-2067 Allow getting raw data from Gremlin.Net.Driver.IGremlinClient