Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2246

Consolidate the error propagation to the client

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.4.2
    • Fix Version/s: 3.3.8, 3.4.3, 3.5.0
    • Component/s: server
    • Labels:
      None

      Description

      Some places in the code base use the ResponseHandlerContext which ensures that only a single response is sent for a particular request [1] but other places do not [2]. This task is to use the ResponseContext consistently across the code base to prevent cases where client gets two messages for the same request (this can break the client when it has removed the RequestQueue thinking that the query is complete and yet a message comes for that request queue).

      [1] https://github.com/apache/tinkerpop/blob/d1a3fa147d1f009ae57274827c9b59426dfc6e58/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/AbstractOpProcessor.java#L100

      [2] https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L315

        Attachments

          Activity

            People

            • Assignee:
              spmallette Stephen Mallette
              Reporter:
              divijvaidya Divij Vaidya
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: