[TINKERPOP-2245] Consolidate the executor for bytecode & string based client

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Done
• Affects Version/s: 3.4.2
• Fix Version/s: 3.5.0
• Component/s: server
• Assignee: Stephen Mallette
• Reporter: Divij Vaidya
• Created: 18/Jun/19 04:46
• Updated: 15/Dec/21 03:05
• Resolved: 16/Apr/21 10:34

Description

We have two code paths in the server which perform (more or less) the same functions. One is the executor for string based queries and other is the executor for bytecode. This code can be refactored together so that the logic to handle timeout, handle exception during execution, handle exception before execution and others can consolidated. 

https://github.com/apache/tinkerpop/blob/master/gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/engine/GremlinExecutor.java#L246

and

https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L333

Issue Links

• is depended upon by: TINKERPOP-709 Consider Bounding Gremlin Pool Queue Size
• links to: DISCUSS