Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2245

[Refactor] Consolidate the executor for bytecode & string based client

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4.2
    • Fix Version/s: None
    • Component/s: server
    • Labels:
      None

      Description

      We have two code paths in the server which perform (more or less) the same functions. One is the executor for string based queries and other is the executor for bytecode. This code can be refactored together so that the logic to handle timeout, handle exception during execution, handle exception before execution and others can consolidated. 

      https://github.com/apache/tinkerpop/blob/master/gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/engine/GremlinExecutor.java#L246

      and

      https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/traversal/TraversalOpProcessor.java#L333

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              divijvaidya Divij Vaidya
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: