Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2215

Better exception message for connection problems

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.1
    • Fix Version/s: 3.5.0, 3.4.7
    • Component/s: dotnet
    • Labels:
      None

      Description

      TheĀ ConnectionPool currently checks whether the pool is empty and then tries to retrieve an available connection if it is not empty. If this fails, then a ConnectionPoolBusyException is thrown with this text:

      All 4 connections have reached their MaxInProcessPerConnection limit of 32. Consider increasing either the PoolSize or the MaxInProcessPerConnection limit.

      However, this exception can also be thrown if all connections in the pool were already closed and were therefore removed from the pool. The exception message doesn't make sense in this case.

      A different exception should be thrown if the pool only contained already closed connections as it's important for users to know whether they actually executed too many requests in parallel or whether there is a connection problem.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              Florian Hockmann Florian Hockmann
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: