[TINKERPOP-2195] Add finally block in HttpGremlinEndpointHandler to commit transaction

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Do
• Affects Version/s: 3.4.2
• Component/s: server
• Assignee: Unassigned
• Reporter: Moayad Alyaghshi
• Created: 09/Apr/19 14:17
• Updated: 16/Apr/19 18:06
• Resolved: 16/Apr/19 18:06

Description

The HttpGremlinEndpointHandler is attempting to commit the transaction before serialisation to be consistent with how things work for websocket, so the transaction will be committed regardless of the serialisation result.

This's causing a performance problem to our implementation which depends on JPA, because serialisation will require to read the entities again from the database since the transaction has been committed and the objects are still managed by the entity manager.

An improvement is to do the serialisation first, and add a finally block to the try...catch statement, where transaction commit can take place.

 

Issue Links

• links to: GitHub Pull Request #1094