Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Done
    • 3.4.0
    • 3.4.0
    • io

    Description

      Add BulkSet as a GraphSON type. Should bring better consistency to how Gremlin works across variants and set things up better for GraphBinary format. This change has a minor "breaking" impact in that 3.4.0 will no longer coerce BulkSet to a List on the server and so a 3.3.x client that gets that type won't know what to do with it.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            spmallette opened a new pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type
            URL: https://github.com/apache/tinkerpop/pull/1018

            https://issues.apache.org/jira/browse/TINKERPOP-2111

            Adding `BulkSet` brings some consistency to how results are processed and sets things up better for GraphBinary. Implemented for all GLVs though they do not yet have `BulkSet` implementations - they simply coerce to `List` during deserialization. This is basically what was happening before but in earlier versions it was happening on the server side.

            All tests pass with `docker/build.sh -t -i`

            VOTE +1

            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.

            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org

            githubbot ASF GitHub Bot added a comment - spmallette opened a new pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type URL: https://github.com/apache/tinkerpop/pull/1018 https://issues.apache.org/jira/browse/TINKERPOP-2111 Adding `BulkSet` brings some consistency to how results are processed and sets things up better for GraphBinary. Implemented for all GLVs though they do not yet have `BulkSet` implementations - they simply coerce to `List` during deserialization. This is basically what was happening before but in earlier versions it was happening on the server side. All tests pass with `docker/build.sh -t -i` VOTE +1 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
            githubbot ASF GitHub Bot added a comment -

            spmallette closed pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type
            URL: https://github.com/apache/tinkerpop/pull/1018

            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.

            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org

            githubbot ASF GitHub Bot added a comment - spmallette closed pull request #1018: TINKERPOP-2111 Added BulkSet as a GraphSON Type URL: https://github.com/apache/tinkerpop/pull/1018 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org

            People

              spmallette Stephen Mallette
              spmallette Stephen Mallette
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: