[TINKERPOP-1862] TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.7
• Fix Version/s: 3.2.8, 3.3.2
• Component/s: process, tinkergraph
• Assignee: Stephen Mallette
• Reporter: Philip Graff
• Created: 03/Jan/18 17:21
• Updated: 05/Mar/18 14:02
• Resolved: 05/Mar/18 14:02

Description

I think the messages are being sent properly in TinkerMessenger, but when I call messenger.receiveMessages(), the vertex is getting messages from the outVertex of their edges regardless of the edge direction. This is due to line 71 of TinkerMessenger (linked below) which calls Edge.vertices(direction).next(), thus getting the first result out of the Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following line 124 of TinkerEdge (linked below), the outVertex is always returned first. TinkerMessenger needs to be modified to return the correct vertex (I think it's the one that != this.vertex).

https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71

https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124

Issue Links

• is blocked by: TINKERPOP-1877 Add new graph data for specialized testing scenarios
• links to: GitHub Pull Request #770
• links to: GitHub Pull Request #777
• links to: GitHub Pull Request #801
• links to: GitHub Pull Request #804