Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.5
    • Fix Version/s: 3.3.0
    • Component/s: process
    • Labels:
      None

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user okram opened a pull request:

        https://github.com/apache/tinkerpop/pull/677

        TINKERPOP-1729: Remove deprecated select steps.

        https://issues.apache.org/jira/browse/TINKERPOP-1729

        There is no point is crying over spilled milk. The deed is done. It had to be done.

        VOTE +1.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/tinkerpop TINKERPOP-1729

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tinkerpop/pull/677.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #677


        commit e0de2b8a84ab43a7cdfce8152c8f4c381f9ce7b6
        Author: Marko A. Rodriguez <okrammarko@gmail.com>
        Date: 2017-07-14T17:11:36Z

        removed deprecated selectV3d0() select step. Updated CHANGELOG and release notes accordingly.

        commit e00902b4ab75d5247402876f298f69462883024b
        Author: Marko A. Rodriguez <okrammarko@gmail.com>
        Date: 2017-07-14T17:22:49Z

        pushed updated graph_traversal.py from template construction.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/677 TINKERPOP-1729 : Remove deprecated select steps. https://issues.apache.org/jira/browse/TINKERPOP-1729 There is no point is crying over spilled milk. The deed is done. It had to be done. VOTE +1. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1729 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/677.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #677 commit e0de2b8a84ab43a7cdfce8152c8f4c381f9ce7b6 Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2017-07-14T17:11:36Z removed deprecated selectV3d0() select step. Updated CHANGELOG and release notes accordingly. commit e00902b4ab75d5247402876f298f69462883024b Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2017-07-14T17:22:49Z pushed updated graph_traversal.py from template construction.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the issue:

        https://github.com/apache/tinkerpop/pull/677

        I had some trouble with this, but once I rebased on master it was fine. I think it's just based on a bad commit on master so once it merges it should be fine.

        All tests pass with `docker/build.sh -t -i`

        VOTE +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/677 I had some trouble with this, but once I rebased on master it was fine. I think it's just based on a bad commit on master so once it merges it should be fine. All tests pass with `docker/build.sh -t -i` VOTE +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the issue:

        https://github.com/apache/tinkerpop/pull/677

        Yes – tested again to be safe.

        ```
        [INFO] ------------------------------------------------------------------------
        [INFO] BUILD SUCCESS
        [INFO] ------------------------------------------------------------------------
        [INFO] Total time: 02:22 h
        [INFO] Finished at: 2017-07-18T16:38:37-06:00
        [INFO] Final Memory: 162M/1473M
        [INFO] ------------------------------------------------------------------------
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/677 Yes – tested again to be safe. ``` [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 02:22 h [INFO] Finished at: 2017-07-18T16:38:37-06:00 [INFO] Final Memory: 162M/1473M [INFO] ------------------------------------------------------------------------ ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the issue:

        https://github.com/apache/tinkerpop/pull/677

        @dkuppitz Can you review this please?

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/677 @dkuppitz Can you review this please?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the issue:

        https://github.com/apache/tinkerpop/pull/677

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/677 VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the issue:

        https://github.com/apache/tinkerpop/pull/677

        Some reason the asfbot was unable to pick up this merge. This was merged – closing.

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/677 Some reason the asfbot was unable to pick up this merge. This was merged – closing.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram closed the pull request at:

        https://github.com/apache/tinkerpop/pull/677

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram closed the pull request at: https://github.com/apache/tinkerpop/pull/677

          People

          • Assignee:
            okram Marko A. Rodriguez
            Reporter:
            okram Marko A. Rodriguez
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development