Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1706

Remove deprecated ScriptEngineCache and related dead code

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.2.5
    • Fix Version/s: 3.3.0
    • Component/s: groovy
    • Labels:

      Description

      ScriptEngineCache was essentially moved in 3.2.4 - the old one can be removed. Includes removal of CoreGremlinPlugin#INSTANCE which is now more consistently referred to as instance() and the old constructor for GremlinJythonScriptEngine

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/655

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/655
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/655

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/655 VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user okram commented on the issue:

          https://github.com/apache/tinkerpop/pull/655

          VOTE +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/655 VOTE +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user spmallette opened a pull request:

          https://github.com/apache/tinkerpop/pull/655

          TINKERPOP-1706 ScriptEngine related deprecation removal

          https://issues.apache.org/jira/browse/TINKERPOP-1706

          Pretty simple and straightforward - these were mostly internal classes/fields/methods.

          Builds nicely with docker

          VOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-1706

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/655.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #655


          commit 33821696cd6c54b4dad94e3f46aed56f55a16c28
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-07-05T19:46:35Z

          TINKERPOP-1706 Removed deprecated ScriptEngineCache and CoreImports

          commit d25487e21009bade2f39215aac64aa6740ba014a
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-07-05T20:26:05Z

          TINKERPOP-1706 Removed access to CoreGremlinPlugin#INSTANCE previously deprecated

          commit d173af8a971b532b9c1e558503406d2bd2743dd8
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-07-05T20:31:34Z

          TINKERPOP-1706 Removed old GremlinJythonScriptEngine constructor.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/655 TINKERPOP-1706 ScriptEngine related deprecation removal https://issues.apache.org/jira/browse/TINKERPOP-1706 Pretty simple and straightforward - these were mostly internal classes/fields/methods. Builds nicely with docker VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1706 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/655.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #655 commit 33821696cd6c54b4dad94e3f46aed56f55a16c28 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-07-05T19:46:35Z TINKERPOP-1706 Removed deprecated ScriptEngineCache and CoreImports commit d25487e21009bade2f39215aac64aa6740ba014a Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-07-05T20:26:05Z TINKERPOP-1706 Removed access to CoreGremlinPlugin#INSTANCE previously deprecated commit d173af8a971b532b9c1e558503406d2bd2743dd8 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-07-05T20:31:34Z TINKERPOP-1706 Removed old GremlinJythonScriptEngine constructor.

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development