Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1680

Add string performance options to StarGraph

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Done
    • 3.2.4
    • 3.2.5
    • structure
    • None

    Description

      I suggest adding a backwards-compatible StarGraph builder exposing a couple minor performance-sensitive behaviors for configuration.

      Specifically:

      • StarGraph calls String#intern on labels
      • StarGraph calls Object#toString on ID elements when testing element-existence-by-id

      It would be nice to have the option to disable these calls in use-cases that don't need them. Disabling the former needs no explanation; disabling the latter would cause cases where element IDs are first toString'ed and then equals-checked to jump straight to the equals check. The performance gain is going to be small and bound to a narrow set of applications, but it's nice to have the choice. It shaved about 3~5% runtime off the use case-case that led me here (via profiling).

      I already tested a local change that adds a builder while neither modifying StarGraph's default behavior nor disturbing any of its existing method/constructor signatures. I'll file a PR against tp32 momentarily.

      Attachments

        Issue Links

          Activity

            People

              spmallette Stephen Mallette
              dalaro Dan LaRocque
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: