[TINKERPOP-1635] gremlin-python: Duplicate serialization of element property in PropertySerializer

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 3.3.0
• Component/s: python
• Assignee: Stephen Mallette
• Reporter: Florian Hockmann
• Created: 18/Feb/17 14:17
• Updated: 13/Sep/17 12:02
• Resolved: 13/Sep/17 12:02

Description

The PropertySerializer in the current master branch of gremlin-python serializes the element property twice:

elementDict = writer.toDict(property.element)
#...
"element": writer.toDict(elementDict)

This isn't a problem when the element only contains simple types like strings that aren't serialized by adding a type attribute (like in the unit test for this component). However, all other types like integers for example are serialized two times. So an integer will be serialized to:

{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":1}}

Full example:

>>> p = Property("aKey","aValue", Edge(123, Vertex(1), "edgeLabel", Vertex(2)))
>>> writer.writeObject(p)
'{"@type":"g:Property","@value":{"value":"aValue","key":"aKey","element":{"@type":"g:Edge","@value":{"inV":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":2}},"id":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":123}},"outV":{"@type":"g:Int32","@value":{"@type":"g:Int32","@value":1}},"label":"edgeLabel"}}}}'

Issue Links

• links to: GitHub Pull Request #561