Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1610

Deprecate gremlin-groovy-test provider based tests

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.2.3
    • Fix Version/s: 3.2.4
    • Component/s: groovy
    • Labels:
      None

      Description

      Given TINKERPOP-1515 and the revised method for testing GLVs we no longer need to require graph providers to test against the groovy environment. Those tests can be deprecated for 3.2.4 and then removed in a later version.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user spmallette opened a pull request:

          https://github.com/apache/tinkerpop/pull/542

          TINKERPOP-1610 Deprecated Groovy test suites

          https://issues.apache.org/jira/browse/TINKERPOP-1610

          Graph Providers no longer need to implement these going forward. Note that the new model for testing groovy will be similar to the approach taken for gremlin-python (which obviously doesn't have all this tests required of the provider). By making this change, we reduce the testing burden on graph providers as this is a whole body of tests they can just ignore now. This is a non-breaking change and will setup for removal and migration of the `gremlin-groovy-test` classes to `gremlin-groovy` (or potentally `gremlin-test` if the test is general enough to aid in testing the `GremlinScriptEngine` environment).

          This is a pretty simple PR at this point, but since it was a major deprecation I wanted to go through the vote process rather than CTR.

          VOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-1610

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/542.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #542


          commit 168d5b37e97b15afc1c9c599035f879e92d6c1c1
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2017-01-20T19:59:25Z

          TINKERPOP-1610 Deprecated Groovy test suites

          Graph Providers no longer need to implement these going forward.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/542 TINKERPOP-1610 Deprecated Groovy test suites https://issues.apache.org/jira/browse/TINKERPOP-1610 Graph Providers no longer need to implement these going forward. Note that the new model for testing groovy will be similar to the approach taken for gremlin-python (which obviously doesn't have all this tests required of the provider). By making this change, we reduce the testing burden on graph providers as this is a whole body of tests they can just ignore now. This is a non-breaking change and will setup for removal and migration of the `gremlin-groovy-test` classes to `gremlin-groovy` (or potentally `gremlin-test` if the test is general enough to aid in testing the `GremlinScriptEngine` environment). This is a pretty simple PR at this point, but since it was a major deprecation I wanted to go through the vote process rather than CTR. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1610 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/542.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #542 commit 168d5b37e97b15afc1c9c599035f879e92d6c1c1 Author: Stephen Mallette <spmva@genoprime.com> Date: 2017-01-20T19:59:25Z TINKERPOP-1610 Deprecated Groovy test suites Graph Providers no longer need to implement these going forward.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/542

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/542 VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user okram commented on the issue:

          https://github.com/apache/tinkerpop/pull/542

          VOTE +1.

          Show
          githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/542 VOTE +1.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/542

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/542

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development