Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536

Just wondering if posting a comment after updating the title will trigger JIRA to connect (or however that works).

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536

And it does. Yay. :+1:

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/536

Is there any reasonable way to write tests for this change?

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536

If you can point me to a test that starts a gremlin-server with a custom config, then I can make that happen.

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536

Looks like I can copy GremlinServerIntegrateTest

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/536

yes you can just add to that test - all the ssl ones are there.

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536

Tests added.

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/536

VOTE: +1

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/536#discussion_r97580891

— Diff: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java —
@@ -105,7 +106,13 @@
*/
public class GremlinServerIntegrateTest extends AbstractGremlinServerIntegrationTest {

• private Log4jRecordingAppender recordingAppender = null;
  + private static final String SERVER_KEY = "src/test/resources/server.key.pk8";
  • • End diff –

some extra spacing here by accident i think

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/536

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/536#discussion_r97582757

— Diff: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java —
@@ -105,7 +106,13 @@
*/
public class GremlinServerIntegrateTest extends AbstractGremlinServerIntegrationTest {

• private Log4jRecordingAppender recordingAppender = null;
  + private static final String SERVER_KEY = "src/test/resources/server.key.pk8";
  • • End diff –

I think I'm using tabs instead of spaces. I can reformat.

Github user twilmes commented on the issue:

https://github.com/apache/tinkerpop/pull/536

Looks good and good doc updates.

VOTE: +1

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/536