Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1602

Support SSL client certificate authentication

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.3
    • Fix Version/s: 3.2.4
    • Component/s: server
    • Labels:

      Description

      Use existing trustCertChainFile. Update docs.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user robertdale commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          Just wondering if posting a comment after updating the title will trigger JIRA to connect (or however that works).

          Show
          githubbot ASF GitHub Bot added a comment - Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 Just wondering if posting a comment after updating the title will trigger JIRA to connect (or however that works).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user robertdale commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          And it does. Yay. :+1:

          Show
          githubbot ASF GitHub Bot added a comment - Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 And it does. Yay. :+1:
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          Is there any reasonable way to write tests for this change?

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/536 Is there any reasonable way to write tests for this change?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user robertdale commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          If you can point me to a test that starts a gremlin-server with a custom config, then I can make that happen.

          Show
          githubbot ASF GitHub Bot added a comment - Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 If you can point me to a test that starts a gremlin-server with a custom config, then I can make that happen.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user robertdale commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          Looks like I can copy GremlinServerIntegrateTest

          Show
          githubbot ASF GitHub Bot added a comment - Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 Looks like I can copy GremlinServerIntegrateTest
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          yes you can just add to that test - all the ssl ones are there.

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/536 yes you can just add to that test - all the ssl ones are there.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user robertdale commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          Tests added.

          Show
          githubbot ASF GitHub Bot added a comment - Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 Tests added.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user robertdale commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/536 VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on a diff in the pull request:

          https://github.com/apache/tinkerpop/pull/536#discussion_r97580891

          — Diff: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java —
          @@ -105,7 +106,13 @@
          */
          public class GremlinServerIntegrateTest extends AbstractGremlinServerIntegrationTest {

          • private Log4jRecordingAppender recordingAppender = null;
            + private static final String SERVER_KEY = "src/test/resources/server.key.pk8";
              • End diff –

          some extra spacing here by accident i think

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/536#discussion_r97580891 — Diff: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java — @@ -105,7 +106,13 @@ */ public class GremlinServerIntegrateTest extends AbstractGremlinServerIntegrationTest { private Log4jRecordingAppender recordingAppender = null; + private static final String SERVER_KEY = "src/test/resources/server.key.pk8"; End diff – some extra spacing here by accident i think
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          All tests pass with `docker/build.sh -t -n -i`

          VOTE +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/536 All tests pass with `docker/build.sh -t -n -i` VOTE +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user robertdale commented on a diff in the pull request:

          https://github.com/apache/tinkerpop/pull/536#discussion_r97582757

          — Diff: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java —
          @@ -105,7 +106,13 @@
          */
          public class GremlinServerIntegrateTest extends AbstractGremlinServerIntegrationTest {

          • private Log4jRecordingAppender recordingAppender = null;
            + private static final String SERVER_KEY = "src/test/resources/server.key.pk8";
              • End diff –

          I think I'm using tabs instead of spaces. I can reformat.

          Show
          githubbot ASF GitHub Bot added a comment - Github user robertdale commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/536#discussion_r97582757 — Diff: gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerIntegrateTest.java — @@ -105,7 +106,13 @@ */ public class GremlinServerIntegrateTest extends AbstractGremlinServerIntegrationTest { private Log4jRecordingAppender recordingAppender = null; + private static final String SERVER_KEY = "src/test/resources/server.key.pk8"; End diff – I think I'm using tabs instead of spaces. I can reformat.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twilmes commented on the issue:

          https://github.com/apache/tinkerpop/pull/536

          Looks good and good doc updates.

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user twilmes commented on the issue: https://github.com/apache/tinkerpop/pull/536 Looks good and good doc updates. VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/536

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/536

            People

            • Assignee:
              rdale Robert Dale
              Reporter:
              rdale Robert Dale
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development