Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.2.3
    • Fix Version/s: 3.2.4
    • Component/s: driver, io, structure
    • Labels:
      None

      Description

      We have indiscriminate use of various versions of instance() (e.g. getInstance() - make it all consistent. Implementing this should use deprecation so as not to be breaking.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user spmallette opened a pull request:

          https://github.com/apache/tinkerpop/pull/489

          TINKERPOP-1530 Consistent use of instance()

          https://issues.apache.org/jira/browse/TINKERPOP-1530

          Deprecated `getInstance()` usage in favor of `instance()`. This is a non-breaking change for 3.2.0. Will likely remove the deprecated methods for 3.3.0 as a breaking change

          All good with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false`

          VOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-1530

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/489.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #489


          commit 185670fa6165d83458326a6b9d80c124966b7402
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2016-11-12T13:13:22Z

          TINKERPOP-1530 Consistent use of instance()

          Deprecated getInstance() usage in favor of instance(). This is a non-breaking change for 3.2.0.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/489 TINKERPOP-1530 Consistent use of instance() https://issues.apache.org/jira/browse/TINKERPOP-1530 Deprecated `getInstance()` usage in favor of `instance()`. This is a non-breaking change for 3.2.0. Will likely remove the deprecated methods for 3.3.0 as a breaking change All good with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1530 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/489.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #489 commit 185670fa6165d83458326a6b9d80c124966b7402 Author: Stephen Mallette <spmva@genoprime.com> Date: 2016-11-12T13:13:22Z TINKERPOP-1530 Consistent use of instance() Deprecated getInstance() usage in favor of instance(). This is a non-breaking change for 3.2.0.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user okram commented on the issue:

          https://github.com/apache/tinkerpop/pull/489

          VOTE +1.

          Show
          githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/489 VOTE +1.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/489

          `docker/build.sh -t -i -n` kinda succeeded (it got stuck in Giraph tests, but I guess it wasn't rebased after this issue had been fixed).

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/489 `docker/build.sh -t -i -n` kinda succeeded (it got stuck in Giraph tests, but I guess it wasn't rebased after this issue had been fixed). VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/489

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/489

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development