[TINKERPOP-1507] Pick.any and Pick.none are not in GraphSON or Gremlin-Python

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.4, 3.2.2
• Fix Version/s: 3.2.3, 3.3.0
• Component/s: io, process, python
• Assignee: Marko A. Rodriguez
• Reporter: Marko A. Rodriguez
• Created: 13/Oct/16 18:22
• Updated: 13/Sep/17 11:57
• Resolved: 13/Sep/17 11:57

Description

There are numerous "tokens" (enums) in Gremlin – T, Order, Compare, etc.

We forgot Pick. Doh. Pick is used in branch-options to support "default" and "all"-type semantics in switch behavior. We need to add it to GraphSON and Gremlin-Python.

More generally, I think we should consolidate all the "tokens" into a single Java file.

public class Tokens {
  public enum T { .. }
  public enum Order { .. }
  public enum VertexCardinality { ..}
  public enum Compare { .. }
  public enum Pick { .. } 
  ...
}

We could make it backwards compatible by:

T.label = Tokens.T.label.

By having all this consolidate, we will more easily know what we have and will be better able to use reflection in language variant generators.

Issue Links

• links to: GitHub Pull Request #460