[TINKERPOP-1505] Transaction Status listener list gets overwritten

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Do
• Affects Version/s: 3.1.4, 3.2.2
• Component/s: structure
• Assignee: Unassigned
• Reporter: Jason Plurad
• Created: 13/Oct/16 16:59
• Updated: 13/Feb/18 18:57
• Resolved: 13/Feb/18 18:57

Description

Transaction status listener is not called when using Gremlin Server

• Caused by the transaction listener list initialization in AbstractThreadLocalTransaction.

• There are 2 different threads in action during the Gremlin Server initialization.

1. The Groovy startup script evaluation which adds the listener
2. The server itself handles the transaction commit or rollback. Both threads end up calling on the ThreadLocal initialValue() which returns new ArrayList() and effectively wipes out the listener.

• Fix is to initialize the list once.

    protected final ThreadLocal<List<Consumer<Transaction.Status>>> transactionListeners = new ThreadLocal<List<Consumer<Transaction.Status>>>() {
        private List<Consumer<Transaction.Status>> list = new ArrayList<>();
        @Override
        protected List<Consumer<Transaction.Status>> initialValue() {
            return list;
        }
    };