Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1420

Remove deprecated ConcurrentBindings in gremlin-groovy

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: groovy
    • Labels:

      Description

      ConcurrentBindings were moved to to gremlin-core - the old class in gremlin-groovy was deprecated and can be removed.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user spmallette opened a pull request:

          https://github.com/apache/tinkerpop/pull/468

          TINKERPOP-1420 Removal of previously deprecated gremlin-groovy classes/methods

          https://issues.apache.org/jira/browse/TINKERPOP-1420

          While this commit is bound to TINKERPOP-1420 it actually also covers TINKERPOP-1283, TINKERPOP-1040 and TINKERPOP-833 which are all "deprecation removal" type tickets. The removed class/methods are all pretty "low-level" for the average user to be using in their code so of all the deprecation we have this one isn't a big deal for removal.

          Builds nicely with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false`

          VOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/tinkerpop TINKERPOP-1420

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tinkerpop/pull/468.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #468


          commit 6c72a9684a8db6b189970d89bca42c7275782019
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2016-10-27T16:22:49Z

          TINKERPOP-1420 Removal of previously deprecated gremlin-groovy classes/methods.

          While this commit is bound to TINKERPOP-1420 it actually also covers TINKERPOP-1283, TINKERPOP-1040 and TINKERPOP-833.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/468 TINKERPOP-1420 Removal of previously deprecated gremlin-groovy classes/methods https://issues.apache.org/jira/browse/TINKERPOP-1420 While this commit is bound to TINKERPOP-1420 it actually also covers TINKERPOP-1283 , TINKERPOP-1040 and TINKERPOP-833 which are all "deprecation removal" type tickets. The removed class/methods are all pretty "low-level" for the average user to be using in their code so of all the deprecation we have this one isn't a big deal for removal. Builds nicely with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1420 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/468.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #468 commit 6c72a9684a8db6b189970d89bca42c7275782019 Author: Stephen Mallette <spmva@genoprime.com> Date: 2016-10-27T16:22:49Z TINKERPOP-1420 Removal of previously deprecated gremlin-groovy classes/methods. While this commit is bound to TINKERPOP-1420 it actually also covers TINKERPOP-1283 , TINKERPOP-1040 and TINKERPOP-833 .
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/468

          `docker/build.sh -t -i -n` fails for me with:

          ```
          Tests run: 490, Failures: 0, Errors: 1, Skipped: 54, Time elapsed: 32.5 sec <<< FAILURE! - in org.apache.tinkerpop.gremlin.groovy.jsr223.RemoteGraphGroovyTranslatorProcessStandardTest
          g_V_repeatXunionXoutXknowsX_groupXaX_byXageX__outXcreatedX_groupXbX_byXnameX_byXcountXX_groupXaX_byXnameXX_timesX2X_capXa_bX(org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.GroupTest$Traversals) Time elapsed: 0.181 sec <<< ERROR!
          java.lang.NullPointerException: null
          at org.apache.tinkerpop.gremlin.process.AbstractGremlinProcessTest.checkSideEffects(AbstractGremlinProcessTest.java:99)
          at org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.GroupTest.g_V_repeatXunionXoutXknowsX_groupXaX_byXageX__outXcreatedX_groupXbX_byXnameX_byXcountXX_groupXaX_byXnameXX_timesX2X_capXa_bX(GroupTest.java:360)
          at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          at java.lang.reflect.Method.invoke(Method.java:498)
          ...
          ```

          I restarted it, but a second attempt usually only "fixes" performance related issues.

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/468 `docker/build.sh -t -i -n` fails for me with: ``` Tests run: 490, Failures: 0, Errors: 1, Skipped: 54, Time elapsed: 32.5 sec <<< FAILURE! - in org.apache.tinkerpop.gremlin.groovy.jsr223.RemoteGraphGroovyTranslatorProcessStandardTest g_V_repeatXunionXoutXknowsX_groupXaX_byXageX__outXcreatedX_groupXbX_byXnameX_byXcountXX_groupXaX_byXnameXX_timesX2X_capXa_bX(org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.GroupTest$Traversals) Time elapsed: 0.181 sec <<< ERROR! java.lang.NullPointerException: null at org.apache.tinkerpop.gremlin.process.AbstractGremlinProcessTest.checkSideEffects(AbstractGremlinProcessTest.java:99) at org.apache.tinkerpop.gremlin.process.traversal.step.sideEffect.GroupTest.g_V_repeatXunionXoutXknowsX_groupXaX_byXageX__outXcreatedX_groupXbX_byXnameX_byXcountXX_groupXaX_byXnameXX_timesX2X_capXa_bX(GroupTest.java:360) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) ... ``` I restarted it, but a second attempt usually only "fixes" performance related issues.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/468

          something weird is going on. i did a `docker/build.sh -t -i -n` on this branch and it works fine. but i can't get #457 to build with that given repeated failures in spark. i wonder what is going on

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/468 something weird is going on. i did a `docker/build.sh -t -i -n` on this branch and it works fine. but i can't get #457 to build with that given repeated failures in spark. i wonder what is going on
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/468

          Took three tries on #457 and then finally built. Not sure what's going on.

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/468 Took three tries on #457 and then finally built. Not sure what's going on.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user dkuppitz commented on the issue:

          https://github.com/apache/tinkerpop/pull/468

          So weird. Build succeeded with `docker/build.sh -t -i -n` after I've rebuilt my containers and removed the `.glv` file from my `gremlin-python` directory.

          VOTE: +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/468 So weird. Build succeeded with `docker/build.sh -t -i -n` after I've rebuilt my containers and removed the `.glv` file from my `gremlin-python` directory. VOTE: +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user spmallette commented on the issue:

          https://github.com/apache/tinkerpop/pull/468

          I've had three goods builds in a row with docker now on this branch. I also cleared my containers/images and it's been good since.

          Show
          githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/468 I've had three goods builds in a row with docker now on this branch. I also cleared my containers/images and it's been good since.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user okram commented on the issue:

          https://github.com/apache/tinkerpop/pull/468

          Huh. Cool. Are we removing deprecations for 3.3.0? If so, should I be doing similar things in the "process" areas of the codebase?

          VOTE +1.

          Show
          githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/468 Huh. Cool. Are we removing deprecations for 3.3.0? If so, should I be doing similar things in the "process" areas of the codebase? VOTE +1.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tinkerpop/pull/468

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/468

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development