Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1392

Remove support for java serialized Traversal

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 3.2.1
    • Fix Version/s: 3.2.2
    • Component/s: server
    • Labels:

      Description

      Given TINKERPOP-1278 and Bytecode serialization of a Traversal the old method of serializing Traversal with java serialization isn't that useful. There seems to be little point in deprecating that functionality because the only library that supports that protocol is gremlin-driver which will now use the new approach. Dropping it completely wouldn't break anyone's code though we still should consider it a "breaking" change.

        Issue Links

          Activity

          Hide
          Ramzi Ramzi Oueslati added a comment -

          Hi

          What if we use JMeter to run tests against Gremlin Server (JMeter does not use gremlin driver) ?

          Show
          Ramzi Ramzi Oueslati added a comment - Hi What if we use JMeter to run tests against Gremlin Server (JMeter does not use gremlin driver) ?
          Hide
          spmallette stephen mallette added a comment -

          I don't follow. How are you using JMeter to send traversals to Gremlin Server if you don't use the java driver?

          Show
          spmallette stephen mallette added a comment - I don't follow. How are you using JMeter to send traversals to Gremlin Server if you don't use the java driver?
          Hide
          Ramzi Ramzi Oueslati added a comment -

          We use a JMeter websocket plugin and send gremlin requests.
          Here is a example of JSON sent through the websocket :

          { "requestId":"1d6d02bd-8e56-421d-9438-3bd6d0079ff1",
          "op":"eval",
          "processor":"",
          "args":{"gremlin":"g.V(someNode)",
          "bindings":

          {"someNode":"someValue"}

          ,
          "language":"gremlin-groovy"}
          }

          Show
          Ramzi Ramzi Oueslati added a comment - We use a JMeter websocket plugin and send gremlin requests. Here is a example of JSON sent through the websocket : { "requestId":"1d6d02bd-8e56-421d-9438-3bd6d0079ff1", "op":"eval", "processor":"", "args":{"gremlin":"g.V(someNode)", "bindings": {"someNode":"someValue"} , "language":"gremlin-groovy"} }
          Hide
          spmallette stephen mallette added a comment -

          that's gremlin-groovy - that hasn't changed. this ticket was about getting rid of serialization of a Traversal via java object serialization. you're not using that.

          Show
          spmallette stephen mallette added a comment - that's gremlin-groovy - that hasn't changed. this ticket was about getting rid of serialization of a Traversal via java object serialization. you're not using that.
          Hide
          Ramzi Ramzi Oueslati added a comment -

          Sorry Stephen. My mistake.
          I upgraded to 3.2.2 and had a few problems and I though it was related.

          Show
          Ramzi Ramzi Oueslati added a comment - Sorry Stephen. My mistake. I upgraded to 3.2.2 and had a few problems and I though it was related.

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development