Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1300

Many asserts around vertex/edge counts on graphs not applied

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.1.2-incubating
    • Fix Version/s: 3.1.3, 3.2.1
    • Component/s: test-suite
    • Labels:
      None

      Description

      A large number of asserts for vertex and edge counts in a graph were not being applied. The break must have happened a long time ago during some refactoring in the test suite.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user spmallette opened a pull request:

          https://github.com/apache/incubator-tinkerpop/pull/311

          TINKERPOP-1300 Fixed many broken count asserts not being applied in test suite.

          https://issues.apache.org/jira/browse/TINKERPOP-1300

          tested with `mvn clean install -DincludeNeo4j`

          VOTE +1

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1300

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-tinkerpop/pull/311.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #311


          commit 111439995ae1a1826cde6d4d8cc2f4601ccc0e0c
          Author: Stephen Mallette <spmva@genoprime.com>
          Date: 2016-05-11T17:10:08Z

          Fixed many broken count asserts not being applied in test suite.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user spmallette opened a pull request: https://github.com/apache/incubator-tinkerpop/pull/311 TINKERPOP-1300 Fixed many broken count asserts not being applied in test suite. https://issues.apache.org/jira/browse/TINKERPOP-1300 tested with `mvn clean install -DincludeNeo4j` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1300 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tinkerpop/pull/311.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #311 commit 111439995ae1a1826cde6d4d8cc2f4601ccc0e0c Author: Stephen Mallette <spmva@genoprime.com> Date: 2016-05-11T17:10:08Z Fixed many broken count asserts not being applied in test suite.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user okram commented on the pull request:

          https://github.com/apache/incubator-tinkerpop/pull/311#issuecomment-218552985

          VOTE +1. This is CTR'able in my opinion.

          Show
          githubbot ASF GitHub Bot added a comment - Github user okram commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/311#issuecomment-218552985 VOTE +1. This is CTR'able in my opinion.

            People

            • Assignee:
              spmallette stephen mallette
              Reporter:
              spmallette stephen mallette
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development