Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1256

Remove Traverser.split(R r, Step<T,R> step)

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Won't Do
    • 3.2.0-incubating
    • None
    • process
    • None

    Description

      I just noticed that Traverser.split(R r, Step<T,R> step) has no implementation that actually uses the step argument. This is an appendage from back in the day when it was always guaranteed that the step would set labels and stepId. This is not the case with many OLAP variations of a step.

      I think we should do the following.

      1. Figure out how to get rid of privat e AbstractStep.prepareTraversalForNextStep() as this is an blemish.
      2. Create Traverser.split(R r).
      3. Then labels are added via traverser.setPath(traverser.getPath().extend(labels)).

      Not a big ticket item, just some nice backwards compatible house-cleaning to remove technical debt.

      Attachments

        Activity

          People

            Unassigned Unassigned
            okram Marko A. Rodriguez
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: