Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-1170

Remove deprecated ConfigurationTraversal.

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2.0-incubating
    • Fix Version/s: 3.3.0
    • Component/s: process
    • Labels:

      Issue Links

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user okram opened a pull request:

        https://github.com/apache/tinkerpop/pull/665

        TINKERPOP-1170: Remove deprecated ConfigurationTraversal.

        https://issues.apache.org/jira/browse/TINKERPOP-1170

        Removed `ConfigurationTraversal` which really should have never been used by anymore, but still. Deprecated accordingly. Its replacement is `PureTraversal`.

        VOTE +1

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/apache/tinkerpop TINKERPOP-1170

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tinkerpop/pull/665.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #665


        commit b0de07fb12685cf8c71a090c10810f18f0a45026
        Author: Marko A. Rodriguez <okrammarko@gmail.com>
        Date: 2017-07-10T20:26:49Z

        removed deprecated ConfigurationTraversal. It was replaced by PureTraversal.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user okram opened a pull request: https://github.com/apache/tinkerpop/pull/665 TINKERPOP-1170 : Remove deprecated ConfigurationTraversal. https://issues.apache.org/jira/browse/TINKERPOP-1170 Removed `ConfigurationTraversal` which really should have never been used by anymore, but still. Deprecated accordingly. Its replacement is `PureTraversal`. VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1170 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/665.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #665 commit b0de07fb12685cf8c71a090c10810f18f0a45026 Author: Marko A. Rodriguez <okrammarko@gmail.com> Date: 2017-07-10T20:26:49Z removed deprecated ConfigurationTraversal. It was replaced by PureTraversal.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user robertdale commented on the issue:

        https://github.com/apache/tinkerpop/pull/665

        Looks like some documentation may need updated. Not sure if this is the same thing. http://tinkerpop.apache.org/docs/current/reference/#program-step

        Show
        githubbot ASF GitHub Bot added a comment - Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/665 Looks like some documentation may need updated. Not sure if this is the same thing. http://tinkerpop.apache.org/docs/current/reference/#program-step
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user okram commented on the issue:

        https://github.com/apache/tinkerpop/pull/665

        No, `ConfigurationTraversal` was replaced by `PureTraversal` and the documentation uses `PureTraversal`.

        ```
        this.traversal = PureTraversal.loadState(configuration, VertexProgramStep.ROOT_TRAVERSAL, graph);
        ```

        Is there somewhere else in particular you are talking about?

        Show
        githubbot ASF GitHub Bot added a comment - Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/665 No, `ConfigurationTraversal` was replaced by `PureTraversal` and the documentation uses `PureTraversal`. ``` this.traversal = PureTraversal.loadState(configuration, VertexProgramStep.ROOT_TRAVERSAL, graph); ``` Is there somewhere else in particular you are talking about?
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user robertdale commented on the issue:

        https://github.com/apache/tinkerpop/pull/665

        I only saw referecences to storeState under http://tinkerpop.apache.org/docs/current/reference/#pagerankvertexprogram (sorry for the previous incorrect link). I'm not familiar with any of this, just want to make sure the docs are synced.

        Show
        githubbot ASF GitHub Bot added a comment - Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/665 I only saw referecences to storeState under http://tinkerpop.apache.org/docs/current/reference/#pagerankvertexprogram (sorry for the previous incorrect link). I'm not familiar with any of this, just want to make sure the docs are synced.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user dkuppitz commented on the issue:

        https://github.com/apache/tinkerpop/pull/665

        VOTE: +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/665 VOTE: +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user spmallette commented on the issue:

        https://github.com/apache/tinkerpop/pull/665

        VOTE +1

        Show
        githubbot ASF GitHub Bot added a comment - Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/665 VOTE +1
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tinkerpop/pull/665

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/665

          People

          • Assignee:
            okram Marko A. Rodriguez
            Reporter:
            okram Marko A. Rodriguez
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development